[do not review] chrore: parse cgroup v2 #3857
Draft
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Oct 3, 2024
| }; | ||
|
|
||
| // For v1 | ||
| constexpr auto base_mem_v1 = "/sys/fs/cgroup/memory"sv; |
There was a problem hiding this comment.
This is wrong. There are no memory.max in root cgroup. That means that always, even before this PR the read_mem(StrCat(base_mem, "/memory.limit_in_bytes"), &mdata->mem_total); would never read anything
See my comments in the GH issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, parsing
cgroupsonly works for version 1. In this version, each controller has its own subfolder so for example when we want to fetch memory controller info we search for files in/sys/fs/cgroup/memory. However, incgroup version 2, all of the controllers reside in the same folder/sys/fs/cgroup/. This PR add support to parseversion 2 cgroupsunder the unified directory model.Probably resolves #3812