feat(rdb_load): add support for loading huge lists #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
previously approved these changes
Oct 2, 2024
romange
reviewed
Oct 2, 2024
romange
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3807 and #3823 to support loading huge lists (#3760).
Note since lists pack 8Kb of entries per node by default, this uses a smaller segment length than the other types. Otherwise we'd only flush every 2GB (4092x8kbx64), whereas with a 512 length segment, we flush every 0.25GB.
Comparing a 5GB list with 1KB elements (
debug populate 1 test 1000 rand type list elements 5000000):main: 3.29s / ~10GiB RSSload-huge-listswith kMaxBlobLen (4092) segment len: 2.77s / ~9GiB RSSload-huge-listswith 512 segment len: 2.21s / ~6.8GiB RSS