Add support for URI format in JSON schema validation #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, and good idea to refactor this! Would you mind adding a couple of tests? |
lapp0
reviewed
Sep 22, 2024
Update URI regex pattern to remove unnecessary `www.` and restrict `@` to the auth portion. Comment added to clarify support for a subset of RFC 3986 (https URLs with optional auth details).
lapp0
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the URI format in JSON schema validation. Previously, attempting to use the "uri" format in a schema would raise a
NotImplementedErrorespecially when serving with vLLM.This change implements regex support for URI validation, allowing users to specify URI fields in their guided JSON requests.