Fail early when Android device is not booted

src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs

@@ -188,7 +188,7 @@ public int GetDeviceApiVersion()
         return apiVersion;
     }
 
-    public void WaitForDevice()
+    public bool WaitForDevice()
     {
         // This command waits for ANY kind of device to be available (emulator or real)
         // Needed because emulators start up asynchronously and take a while.
@@ -215,10 +215,12 @@ public void WaitForDevice()
         if (bootCompleted)
         {
             _log.LogDebug($"Waited {(int)watch.Elapsed.TotalSeconds} seconds for device boot completion");
+            return true;
         }
         else
         {
-            _log.LogWarning($"Did not detect boot completion variable on device; device may be in a bad state");
+            _log.LogError($"Did not detect boot completion variable on device; device may be in a bad state");
+            return false;
         }
     }
 

src/Microsoft.DotNet.XHarness.CLI/Commands/Android/AndroidInstallCommand.cs

@@ -108,7 +108,10 @@ public static ExitCode InvokeHelper(
             runner.TimeToWaitForBootCompletion = bootTimeoutSeconds;
 
             // Wait till at least device(s) are ready
-            runner.WaitForDevice();
+            if (!runner.WaitForDevice())
+            {
+                return ExitCode.DEVICE_NOT_FOUND;
+            }
 
             logger.LogDebug($"Working with {device.DeviceSerial} (API {device.ApiVersion})");
 

src/Microsoft.DotNet.XHarness.CLI/Commands/Android/AndroidRunCommand.cs

@@ -53,7 +53,10 @@ protected override ExitCode InvokeCommand(ILogger logger)
         runner.TimeToWaitForBootCompletion = Arguments.LaunchTimeout;
 
         // Wait till at least device(s) are ready
-        runner.WaitForDevice();
+        if (!runner.WaitForDevice())
+        {
+            return ExitCode.DEVICE_NOT_FOUND;
+        }
 
         logger.LogDebug($"Working with API {runner.GetAdbVersion()}");
 

src/Microsoft.DotNet.XHarness.CLI/Commands/AndroidHeadless/AndroidHeadlessInstallCommand.cs

@@ -103,7 +103,10 @@ public static ExitCode InvokeHelper(
             runner.TimeToWaitForBootCompletion = bootTimeoutSeconds;
 
             // Wait till at least device(s) are ready
-            runner.WaitForDevice();
+            if (!runner.WaitForDevice())
+            {
+                return ExitCode.DEVICE_NOT_FOUND;
+            }
 
             logger.LogDebug($"Working with {device.DeviceSerial} (API {device.ApiVersion})");
 

src/Microsoft.DotNet.XHarness.CLI/Commands/AndroidHeadless/AndroidHeadlessRunCommand.cs

@@ -52,7 +52,10 @@ protected override ExitCode InvokeCommand(ILogger logger)
         runner.TimeToWaitForBootCompletion = Arguments.LaunchTimeout;
 
         // Wait till at least device(s) are ready
-        runner.WaitForDevice();
+        if (!runner.WaitForDevice())
+        {
+            return ExitCode.DEVICE_NOT_FOUND;
+        }
 
         return InvokeHelper(
             logger,