Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Delete Decrypt_Pkcs1_ErrorsForInvalidPadding #99654

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 13, 2024

Backport of #99373 to release/7.0-staging

/cc @vcsjones @bartonjs

This is a test only change. It deletes a test that can fail nondeterministically. A better test already exists and its behavior is deterministic. That test was introduced in #98390 for release/7.0.

Risk

None. Test only change.

Fixes #99652

This test has a small random chance of failure because of non-determinism. The test Decrypt_Pkcs1_BadPadding covers this scenario and is properly deterministic, so let's go ahead and delete the test that has a chance of failing.
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

@bartonjs bartonjs added the Servicing-approved Approved for servicing release label Mar 13, 2024
@bartonjs bartonjs merged commit 643aa17 into release/7.0-staging Mar 13, 2024
109 of 118 checks passed
@bartonjs bartonjs deleted the backport/pr-99373-to-release/7.0-staging branch March 13, 2024 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security Servicing-approved Approved for servicing release test-bug Problem in test source code (most likely)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants