Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Adding osx-arm64 Mono Interpreter runtime tests job to extra-platforms #96023

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Dec 14, 2023

Description

This PR adds osx-arm64 Mono interpreter runtime tests job to runtime-extra-platforms.

Motivation

Currently, we have coverage for Mono on osx-x64 (miniJIT and interpreter) as part of runtime CI job but we are lacking coverage over arm64 for Apple platforms. We have Mono jobs running on Apple arm64 (ios/tvos_arm64_AllSubsets_Mono_RuntimeTests) but these are running very limited set of runtime tests (#84254). We need this coverage for testing Swift Interop support.

Until we have sufficient coverage over runtime tests for Apple arm64 mobile platforms it would be good to have at least some coverage for Apple arm64.

@ghost
Copy link

ghost commented Dec 14, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Description

This PR adds osx-arm64 Mono interpreter runtime tests job to runtime-extra-platforms.

Motivation

Currently, we have coverage for Mono on osx-x64 (miniJIT and interpreter) as part of runtime CI job but we are lacking coverage over arm64 for Apple platforms. We have Mono jobs running on Apple arm64 (ios/tvos_arm64_AllSubsets_Mono_RuntimeTests) but these are running very limited set of runtime tests (#84254).

Until we have sufficient coverage over runtime tests for Apple arm64 mobile platforms it would be good to have at least some coverage for Apple arm64.

Author: matouskozak
Assignees: matouskozak
Labels:

area-Infrastructure-mono

Milestone: -

@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak
Copy link
Member Author

matouskozak commented Dec 15, 2023

Failures in JIT/SIMD/Vector3Interop_r/ro

Error message:

nativeCall_PInvoke_CheckVector3Size: sizeof(Vector3) == 12
nativeCall_PInvoke_Vector3Arg:
    iVal 123
    sumOfEles(1.000000, 2.000000, 3.000000) = 6.000000
    str  abcdefg
    sumOfEles(10.000000, 11.000000, 12.000000) = 33.000000
PInvoke Vector3Arg_Unix test failed
Xunit.Sdk.EqualException: Assert.Equal() Failure: Values differ
Expected: 100
Actual:   101
   at Xunit.Assert.Equal[Int32](Int32 expected, Int32 actual, IEqualityComparer`1 comparer) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 139
   at Xunit.Assert.Equal[Int32](Int32 expected, Int32 actual) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 83
   at __GeneratedMainWrapper.Main()
nativeCall_PInvoke_Vector3Arg_Unix:
    v3f32_xmm0: 1.000000 2.000000 3.000000
    f32_xmm2 - f32_xmm7: 100.000000 101.000000 102.000000 103.000000 104.000000 105.000000
    f32_mem0: 106.000000
    v3f32_mem1: 10.000000 20.000000 30.000000
    f32_mem2-3: 0.000000 107.000000
    sum = 894.000000
Expected: 100
Actual: 101

The same tests are passing on runtime osx-x64 miniJIT and interpreter CI jobs.

Edit: disabled and tracked #96051

@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak matouskozak changed the title [WIP][mono] Adding osx-arm64 Mono Interpreter runtime tests job to extra-platforms [mono] Adding osx-arm64 Mono Interpreter runtime tests job to extra-platforms Dec 15, 2023
@matouskozak matouskozak marked this pull request as ready for review December 15, 2023 17:11
@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SamMonoRT
Copy link
Member

@steveisok - do we need approval from any infra folks for this PR?

@akoeplinger
Copy link
Member

do we need approval from any infra folks for this PR?

I don't think so, the additional job targets osx_arm64 and we usually have enough capacity there.

@matouskozak
Copy link
Member Author

/azp run runtime-extra-platforms

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matouskozak matouskozak merged commit 2f328f1 into dotnet:main Jan 15, 2024
229 of 242 checks passed
tmds pushed a commit to tmds/runtime that referenced this pull request Jan 23, 2024
…latforms (dotnet#96023)

* Add osx_arm64 Mono interpreter runtime tests to runtime-extra-platforms CI
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
@matouskozak matouskozak deleted the new-osx-arm64-interpreter-ci branch October 3, 2024 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants