Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF][Release/7.0] Add newer container for performance Android testing #95883

Conversation

LoopedBard3
Copy link
Member

Fixes: dotnet/performance#3527
Successful test run (Android only): https://dev.azure.com/dnceng/internal/_build/results?buildId=2333679&view=results

Add performance android build specific platform-matrix entry with specific image to fix android app build/run issues. This only impacts performance testing and is an infra only change.

I added to the platform-matrix rather that updating the previously used platform-matrix entry to remove chance of any other impacts from changing the container image. I am not set on this way so let me know if a different approach is preferred.

@dotnet/runtime-infrastructure can I get this 'servicing-approved'? This only impacts performance testing infra. I am also open to any preferences on better ways to do this container update. Thanks!

…cific image to fix android app build/run issues.
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: dotnet/performance#3527
Successful test run (Android only): https://dev.azure.com/dnceng/internal/_build/results?buildId=2333679&view=results

Add performance android build specific platform-matrix entry with specific image to fix android app build/run issues. This only impacts performance testing and is an infra only change.

I added to the platform-matrix rather that updating the previously used platform-matrix entry to remove chance of any other impacts from changing the container image. I am not set on this way so let me know if a different approach is preferred.

@dotnet/runtime-infrastructure can I get this 'servicing-approved'? This only impacts performance testing infra. I am also open to any preferences on better ways to do this container update. Thanks!

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-mono

Milestone: -

Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LoopedBard3
Copy link
Member Author

LoopedBard3 commented Dec 12, 2023

@carlossanlop can you take a quick look over this? Thanks!

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Dec 13, 2023
@carlossanlop carlossanlop merged commit d776e5e into dotnet:release/7.0-staging Dec 13, 2023
142 of 165 checks passed
@LoopedBard3 LoopedBard3 deleted the Perf7.0FixAndroidBuildProblem branch December 18, 2023 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants