Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] [Android] Bump target SDK version for Android sample #95770

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Dec 7, 2023

Backport of #80923 to release/7.0-staging

/cc @simonrozsival

This is a test-only change.

Prior to this change, the Android sample app located at src/mono/sample/Android have been failing to install on phones with Android SDK 31+. The error message looks like this

This app was built for an older version of Android and doesn't include the latest privacy protections. 

Installing this app may put your device at risk. Learn more (https://support.google.com/android/answer/2812853?hl=en) about Play Protect.

We use this app to benchmark android app size and startup time. Because of this issue, we weren't able to get data for .NET7 since early November.

This PR added the targetSdkVersion switch and setting it to Android SDK 31. This ensured that the Android app is built for the SDK version aligned with the devices used for testing in the perf lab.

Customer Impact

There is no customer impact. This change is for testing only.

Testing

Validated manually that the Android sample app located at src/mono/sample/Android is able to install on phones with Android SDK 31+ without error.

Risk

None

@ghost
Copy link

ghost commented Dec 7, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #80923 to release/7.0-staging

/cc @simonrozsival

Customer Impact

There is no customer impact. This change is for testing only.

Testing

Validated that the Android sample app located at src/mono/sample/Android is able to install on phones with Android SDK 31+ without error.

Risk

None

Author: fanyang-mono
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@fanyang-mono fanyang-mono added the Servicing-consider Issue for next servicing release review label Dec 7, 2023
@fanyang-mono fanyang-mono changed the title [Android] Bump target SDK version for Android sample [release/7.0-staging] [Android] Bump target SDK version for Android sample Dec 7, 2023
@fanyang-mono
Copy link
Member Author

CI failures are unrelated to this PR.

@fanyang-mono fanyang-mono added this to the 7.0.x milestone Dec 11, 2023
@fanyang-mono fanyang-mono added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 11, 2023
@fanyang-mono
Copy link
Member Author

@carlossanlop This is a test-only change.

@fanyang-mono fanyang-mono merged commit 9f6b5d6 into release/7.0-staging Dec 11, 2023
147 of 177 checks passed
@carlossanlop
Copy link
Member

@fanyang-mono are the files under src/tasks only used by tests?

src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs

@fanyang-mono
Copy link
Member Author

fanyang-mono commented Dec 11, 2023

@fanyang-mono are the files under src/tasks only used by tests?

src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs

yes. We (Mono runtime developers) use it to validate runtime related changes to make sure they works properly with Android apps. .NET Android/MAUI apps doesn't use AndroidAppBuilder to build apps.

@carlossanlop carlossanlop deleted the backport_80923_to_7 branch December 11, 2023 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants