-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-staging] [Android] Bump target SDK version for Android sample #95770
Conversation
Tagging subscribers to this area: @directhex Issue DetailsBackport of #80923 to release/7.0-staging /cc @simonrozsival Customer ImpactThere is no customer impact. This change is for testing only. TestingValidated that the Android sample app located at RiskNone
|
CI failures are unrelated to this PR. |
@carlossanlop This is a test-only change. |
@fanyang-mono are the files under src/tasks/AndroidAppBuilder/AndroidAppBuilder.cs |
yes. We (Mono runtime developers) use it to validate runtime related changes to make sure they works properly with Android apps. .NET Android/MAUI apps doesn't use |
Backport of #80923 to release/7.0-staging
/cc @simonrozsival
This is a test-only change.
Prior to this change, the Android sample app located at
src/mono/sample/Android
have been failing to install on phones with Android SDK 31+. The error message looks like thisWe use this app to benchmark android app size and startup time. Because of this issue, we weren't able to get data for .NET7 since early November.
This PR added the
targetSdkVersion
switch and setting it toAndroid SDK 31
. This ensured that the Android app is built for the SDK version aligned with the devices used for testing in the perf lab.Customer Impact
There is no customer impact. This change is for testing only.
Testing
Validated manually that the Android sample app located at
src/mono/sample/Android
is able to install on phones with Android SDK 31+ without error.Risk
None