[release/8.0-staging] Clean up the thread local memory regardless of managed thread's presence #95722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jkotas
approved these changes
Dec 7, 2023
JulieLeeMSFT
removed
the
Servicing-consider
mangod9
reviewed
Dec 8, 2023
| t_ThreadStatics.NonGCThreadStaticBlocks = nullptr; | ||
|
|
||
| delete[] t_ThreadStatics.GCThreadStaticBlocks; | ||
| t_ThreadStatics.GCThreadStaticBlocks = nullptr; |
There was a problem hiding this comment.
believe this is just cleanup based on last PR, and doesn't affect the fix?
There was a problem hiding this comment.
Correct - this addressed @AaronRobinsonMSFT's comment in #95362 (comment)
mangod9
approved these changes
Dec 8, 2023
kouvel
approved these changes
Dec 8, 2023
jeffschwMSFT
approved these changes
Dec 14, 2023
JulieLeeMSFT
added
the
Servicing-consider
rbhanda
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95715 to release/8.0-staging
/cc @kunalspathak
Customer Impact
#95362 doesn't fully solve the problem of memory leak and our customer has reported that the leak still exists. I have provided the binaries that contains the fix in this PR and they confirmed that it solved the memory leak problem.
Testing
Verified it manually with the C# application mentioned in #95715.
The customer confirmed that it passed their test.
Risk
Not risky because we will free the thread local memory only during the corresponding thread's termination.
IMPORTANT: If this backport is for a servicing release, please verify that:
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.