Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NugetProjectModelVersion and NugetPackagingVersion #94613

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update NugetProjectModelVersion and NugetPackagingVersion #94613

merged 1 commit into from
Nov 15, 2023

Conversation

agocke
Copy link
Member

@agocke agocke commented Nov 10, 2023

(cherry picked from commit 97c96d4)

@LoopedBard3 @agocke
Update NugetProjectModelVersion and NugetPackagingVersion from 6.2.2 …
ffb6a59 
…to 6.2.4 (dotnet#88107)

* Update Nuget Package Versions.

* Update another Nuget Value.

(cherry picked from commit 97c96d4)
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 10, 2023
@ghost ghost assigned agocke Nov 10, 2023
@build-analysis build-analysis bot mentioned this pull request Nov 10, 2023
Open
@carlossanlop carlossanlop added area-Infrastructure Servicing-approved Approved for servicing release and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 13, 2023
@ghost
Copy link

ghost commented Nov 13, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

(cherry picked from commit 97c96d4)

Author: agocke
Assignees: agocke
Labels:

area-Infrastructure
Milestone: -

carlossanlop
carlossanlop approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the CI looks good, LGTM.

Was there a reason why you decided to only cherry-pick one of the two commits? https://github.com/dotnet/runtime/pull/88107/files

Friendly reminder: If you'd like this to be included in the December release, please merge it before Tuesday November 14th EOD (Code Complete).

@carlossanlop
Copy link
Member

CI failure is #91987

@akoeplinger
Copy link
Member

Was there a reason why you decided to only cherry-pick one of the two commits? #88107 (files)

The release/7.0 Version.Details.xml doesn't have entries for these packages.

FYI this currently targets release/7.0 instead of release/7.0-staging.

@carlossanlop
Copy link
Member

FYI this currently targets release/7.0 instead of release/7.0-staging.

Since today is Code Complete, this can stay targeting the release/7.0 branch, to save time. The change will automatically flow into staging, that's less urgent.

@agocke
Copy link
Member Author

agocke commented Nov 15, 2023

Yup, version.details.xml doesn't have this. I'm not trying to fix that in this PR.

@agocke agocke merged commit ecd4b95 into dotnet:release/7.0 Nov 15, 2023
172 of 179 checks passed
@agocke agocke deleted the backport-88107 branch November 15, 2023 19:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@jeffschwMSFT jeffschwMSFT Awaiting requested review from jeffschwMSFT

Assignees

@agocke agocke

Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agocke @carlossanlop @akoeplinger @ViktorHofer @LoopedBard3