-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow binder gen diag locations correctly & pick up more bind input patterns #89537
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsFixes #88865.
|
7ab42ba
to
5436e51
Compare
Still iterating on the approach to take here. Per offline discussion with @ericstj we could tie each diagnostic to the binding invocation that specifies an input graph that contains types that we'd issue diagnostics for. Will push another commit. Unsure what the issue with |
Trace switch issue appears to be related to d4d0812 - pull the latest from main to your branch to see a local repro. cc @tarekgh |
5436e51
to
577576e
Compare
7a01462
to
96827f4
Compare
96827f4
to
232679d
Compare
Refreshed the PR to take this approach, rather than tie diagnostics to the locations of unsupported type or property definitions. |
232679d
to
3ed8471
Compare
cc @eduherminio I verified that this PR fixes your repro #89732 (comment). |
e2bbcbe
to
7f68238
Compare
...libraries/Microsoft.Extensions.Configuration.Binder/tests/Common/ConfigurationBinderTests.cs
Show resolved
Hide resolved
…braryTests_EAT to unblock PR.
Fixes #88865.
Fixes #89273.
Fixes #89732.
Closes #86653 (adds test).