Implement IKeyedServiceProvider interface on ServiceProviderEngineScope #89509
Conversation
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-extensions-dependencyinjection Issue DetailsMy take on #89447 Mainly, just implemented the missing interface on ServiceProviderEngineScope. I don't know whether I missed something obscure with regards to the keyed feature -- I'm not an expert in the area -- but both cases I mentioned in the issue seem to work fine with the fix. Fixes #89447
|
...ns.DependencyInjection.Specification.Tests/src/KeyedDependencyInjectionSpecificationTests.cs
Outdated
Show resolved
Hide resolved
...ns.DependencyInjection.Specification.Tests/src/KeyedDependencyInjectionSpecificationTests.cs
Outdated
Show resolved
Hide resolved
...ies/Microsoft.Extensions.DependencyInjection/src/ServiceLookup/ServiceProviderEngineScope.cs
Show resolved
Hide resolved
|
Test failures are unrelated (#83659) |
|
@steveharter PTAL (or can I just merge this given @halter73's approval?) |
|
FYI, this is blocking ASP.NET Core trying to use keyed DI. e.g. in frameworks like SignalR, Minimal, MVC, Blazor. The sooner this gets in the more time we will have to attempt to update the frameworks with support for the feature for 8.0 😃 |
|
It's tempting to ask for a preview7 backport even though it is late. |
|
Ok I'm merging it by CET EOD today, given it is blocking ASP.NET Core -- and dotnet/extensions (dotnet/extensions#4211, dotnet/extensions#4222), and NCL... |
My take on #89447
Mainly, just implemented the missing interface on ServiceProviderEngineScope.
I don't know whether I missed something obscure with regards to the keyed feature -- I'm not an expert in the area -- but both cases I mentioned in the issue seem to work fine with the fix.
Fixes #89447