Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AssemblyMetadata(".NETFrameworkAssembly", "") attributes #89490

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Remove AssemblyMetadata(".NETFrameworkAssembly", "") attributes #89490

merged 3 commits into from
Jul 27, 2023

Commits on Jul 26, 2023

  1. Remove AssemblyMetadata(".NETFrameworkAssembly", "") attributes 

    This is likely a .NET Native leftover that is currently (ironically) breaking .NET Native. This attribute indicates to the .NET Native compiler that the assembly can be trimmed.

We're currently setting this on assemblies that no longer carry RD.XML to make this safe. Without this attribute, the assembly will be treated like any other and not trimmed.

Fixes dotnet#44697.
    @MichalStrehovsky
    MichalStrehovsky committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c79e7ac View commit details
    Browse the repository at this point in the history

  2. Update eng/versioning.targets

    @jkotas
    jkotas authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    406f805 View commit details
    Browse the repository at this point in the history

  3. Delete mention of the attribute in docs

    @jkotas
    jkotas committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    f75e89b View commit details
    Browse the repository at this point in the history