Remove S.S.Permissions reference from S.DirectoryServices #82453

steveharter · 2023-02-21T23:01:05Z

Contributes to #64592.

The approach is mostly based on ericstj@3426ddd which is described at #64592 (comment). Basically, there are 5 types in S.DS that depend on types from S.S.P and this PR moves those to S.S.P so that the unwanted dependency from S.DS to S.S.P is removed. Those 5 types are either obsolete (CAS-related) or used only in parameters in those obsolete methods so they would not normally be referenced \ used.

This is considered a breaking change and may require in rare cases an extra reference to S.S.P (if any of the 5 types are referenced).

The System.DirectoryServices.nuspec goes from:


    <dependencies>
      <group targetFramework="net6.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net7.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net8.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.IO.FileSystem.AccessControl" version="5.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.AccessControl" version="6.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>

to

    <dependencies>
      <group targetFramework="net6.0" />
      <group targetFramework="net7.0" />
      <group targetFramework="net8.0" />
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.IO.FileSystem.AccessControl" version="5.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.AccessControl" version="6.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>

See also #82259 which removes the S.S.P dependency from System.Configuration.ConfigurationManager.

Details:

The S.DS project does not have a netfx build; netfx has its own copy of the assembly.
- The 5 types are forwarded to S.S.P for netcore\netstandard. The netfx version is not changed of course and the 5 types continue to live in S.DS.
The S.S.P project has a netfx build (along with netcore and netstandard)
- The 5 types now live here for netcore\netstandard but forward to S.DS for netfx.

ghost · 2023-02-21T23:03:36Z

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

ghost · 2023-02-23T14:55:01Z

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #64592.

The approach is mostly based on ericstj@3426ddd which is described at #64592 (comment). Basically, the 5 types in S.DS that depend on types from S.S.P are being moved to S.S.P in order to remove the unwanted dependency from S.DS to S.S.P. Those 5 types are either obsolete or used only in parameters in obsolete CAS-related methods.

This will still be considered a breaking change, and may require in rare cases (if the obsolete types are used) an extra reference to S.S.P.

The System.DirectoryServices.nuspec goes from:


    <dependencies>
      <group targetFramework="net6.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net7.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework="net8.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
      </group>
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.Security.Permissions" version="8.0.0-dev" exclude="Build,Analyzers" />
        <dependency id="System.IO.FileSystem.AccessControl" version="5.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.AccessControl" version="6.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>

to

    <dependencies>
      <group targetFramework="net6.0" />
      <group targetFramework="net7.0" />
      <group targetFramework="net8.0" />
      <group targetFramework=".NETStandard2.0">
        <dependency id="System.IO.FileSystem.AccessControl" version="5.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.AccessControl" version="6.0.0" exclude="Build,Analyzers" />
        <dependency id="System.Security.Principal.Windows" version="5.0.0" exclude="Build,Analyzers" />
      </group>
    </dependencies>

See also #82259 which removes the S.S.P dependency from S.Configuration.ConfigurationManager.

Author:	steveharter
Assignees:	steveharter
Labels:	`area-System.DirectoryServices`, `breaking-change`, `needs-breaking-change-doc-created`
Milestone:	8.0.0

src/libraries/System.DirectoryServices/ref/System.DirectoryServices.csproj

...ries/System.Security.Permissions/src/System/DirectoryServices/DirectoryServicesPermission.cs

src/libraries/System.DirectoryServices/src/System.DirectoryServices.csproj

src/libraries/System.Security.Permissions/src/CompatibilitySuppressions.xml

…r NetFx

ericstj · 2023-03-15T16:19:57Z

src/libraries/System.DirectoryServices/src/CompatibilitySuppressions.xml

+<?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+  <Suppression>


These errors are all saying that you are missing the type-forwards from the implementation assembly.

The forwards were added; the "baseline" suppressions are still necessary.

They should not be necessary. API Compat should not raise the error if the type is forwarded - it should see that forward and compare the forwarded definition.

@ViktorHofer looks like something is going wrong with APICompat following type forwards. I pulled this branch and reproduced it. I can inspect the assemblies and I see that the new S.DS has a type forward for these types in S.S.P and the types exist there.

@steveharter please file an issue for this and merge with the suppression.

Created https://github.com/dotnet/runtime/issues/83555

src/libraries/System.DirectoryServices/ref/System.DirectoryServices.manual.cs

…st project

ericstj

LGTM though we need to find out why APICompat doesn't follow the forward. That can be handled separately.

steveharter · 2023-03-16T21:12:43Z

Logged #83551 for CI failures:

System.Runtime.Serialization.Xml.XsdDataContractExporterTests.ExporterApiTests.Export(testname: "Exp2", export: Action`1 { Method = Void <Export_MemberData>b__7_2(System.Runtime.Serialization.XsdDataContractExporter), Target = <>c { } }, schemaCheck: Action`2 { Method = Void <Export_MemberData>b__3(System.String, System.Xml.Schema.XmlSchemaSet), Target = <>c__DisplayClass7_0 { autoImportKVP = False } })
DataContractSerializerTests.DCS_MemoryStream_Serialize_UsesBuiltInAdapter
DataContractSerializerTests.DCS_FileStreamSurrogate

Other failures appear related to #83482.

steveharter · 2023-08-16T19:18:20Z

Breaking change issue: dotnet/docs#36724

Remove S.S.Permissions reference from S.DirectoryServices

74c6494

steveharter added this to the 8.0.0 milestone Feb 21, 2023

steveharter requested review from ViktorHofer, ericstj and buyaa-n February 21, 2023 23:01

steveharter self-assigned this Feb 21, 2023

steveharter added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Feb 21, 2023

ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Feb 21, 2023

build-analysis bot mentioned this pull request Feb 22, 2023

Tracking issue for CI build timeouts #76454

Closed

steveharter added 3 commits February 22, 2023 09:09

Fix typo on reference name

28be823

Change from Reference to ProjectReference for NetFramework

937d30e

Use per-package suppression file for testPackages

f509711

steveharter added the area-System.DirectoryServices label Feb 23, 2023

build-analysis bot mentioned this pull request Feb 23, 2023

Roslyn source generator crash on mono/linux/arm64 #81123

Closed

ericstj reviewed Mar 1, 2023

View reviewed changes

src/libraries/System.DirectoryServices/ref/System.DirectoryServices.csproj Show resolved Hide resolved

...ries/System.Security.Permissions/src/System/DirectoryServices/DirectoryServicesPermission.cs Outdated Show resolved Hide resolved

Add back [Obsolete]; use explicit suppresions

c51d221

steveharter requested a review from ericstj March 8, 2023 21:01

steveharter commented Mar 8, 2023

View reviewed changes

src/libraries/System.DirectoryServices/src/System.DirectoryServices.csproj Outdated Show resolved Hide resolved

ericstj reviewed Mar 13, 2023

View reviewed changes

src/libraries/System.Security.Permissions/src/CompatibilitySuppressions.xml Outdated Show resolved Hide resolved

Use explicit suppressions for CP0001

7113895

dotnet deleted a comment from ericstj Mar 13, 2023

steveharter force-pushed the DS_to_SSP branch from a391a8d to 4aa845f Compare March 14, 2023 15:41

Remove S.S.DS suppressions in S.S.P and suppport NetStandard build fo…

4d26149

…r NetFx

steveharter force-pushed the DS_to_SSP branch from 4aa845f to 4d26149 Compare March 14, 2023 15:42

Fix compile error in System.Runtime.Serialization.Formatters\tests

452130a

build-analysis bot mentioned this pull request Mar 14, 2023

NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723

Open

5 tasks

steveharter added 2 commits March 14, 2023 15:35

Attempt to fix package test error for S.DS.CM

4232620

Remove unnecessary reference from test project

cf7bb97

ericstj reviewed Mar 15, 2023

View reviewed changes

src/libraries/System.DirectoryServices/ref/System.DirectoryServices.manual.cs Outdated Show resolved Hide resolved

steveharter added 5 commits March 16, 2023 09:13

Add forwards to S.DS csproj impl; forward from S.S.P to S.DS for netfx

a196e1c

Add back testPackages suppression; remove unnecessary reference in te…

6eb80ff

…st project

Add S.S.P ref to System.Runtime.Serialization.Formatters/tests

d9fdf56

Add back another testPackages suppression

f8e5be8

Merge branch 'main' of https://github.com/dotnet/runtime into DS_to_SSP

702cc9c

ericstj approved these changes Mar 16, 2023

View reviewed changes

steveharter mentioned this pull request Mar 16, 2023

CI failures on System.Runtime.Serialization.Xml.Tests #83551

Open

steveharter merged commit 4c25072 into dotnet:main Mar 16, 2023

steveharter deleted the DS_to_SSP branch March 16, 2023 21:27

This was referenced Mar 17, 2023

Unnecessary ApiCompat CP0001 errors when type forwards used dotnet/sdk#31271

Closed

[API Proposal]: remove dependency on System.Drawing.Common from System.Configuration.ConfigurationManager #64592

Closed

build-analysis bot mentioned this pull request Mar 16, 2023

Crashes when initializing System.Net.Security.Native #83540

Closed

ghost locked as resolved and limited conversation to collaborators Apr 16, 2023

steveharter removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove S.S.Permissions reference from S.DirectoryServices #82453

Remove S.S.Permissions reference from S.DirectoryServices #82453

steveharter commented Feb 21, 2023 •

edited

Loading

ghost commented Feb 21, 2023 •

edited by steveharter

Loading

ghost commented Feb 23, 2023

ericstj Mar 15, 2023

steveharter Mar 16, 2023

ericstj Mar 16, 2023

ericstj Mar 16, 2023

steveharter Mar 16, 2023

ericstj left a comment

steveharter commented Mar 16, 2023 •

edited

Loading

steveharter commented Aug 16, 2023

Remove S.S.Permissions reference from S.DirectoryServices #82453

Remove S.S.Permissions reference from S.DirectoryServices #82453

Conversation

steveharter commented Feb 21, 2023 • edited Loading

ghost commented Feb 21, 2023 • edited by steveharter Loading

ghost commented Feb 23, 2023

ericstj Mar 15, 2023

Choose a reason for hiding this comment

steveharter Mar 16, 2023

Choose a reason for hiding this comment

ericstj Mar 16, 2023

Choose a reason for hiding this comment

ericstj Mar 16, 2023

Choose a reason for hiding this comment

steveharter Mar 16, 2023

Choose a reason for hiding this comment

ericstj left a comment

Choose a reason for hiding this comment

steveharter commented Mar 16, 2023 • edited Loading

steveharter commented Aug 16, 2023

steveharter commented Feb 21, 2023 •

edited

Loading

ghost commented Feb 21, 2023 •

edited by steveharter

Loading

steveharter commented Mar 16, 2023 •

edited

Loading