JIT: broaden cloning invariant checks #70232
Conversation
Streamline call effects checks. Use wider bit vectors. Closes dotnet#70100.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsStreamline call effects checks. Use wider bit vectors. Closes #70100.
|
|
Unsurprisingly, leads to more cloning. Some fairly sizeable regressions. We probably need to consider backing off cloning really large loops, especially if evidence of benefit is thin. @BruceForstall PTAL |
| // If caller is worried about possible indirect effects, check | ||
| // what we know about the calls in the loop. | ||
| // | ||
| if (inds != 0) |
There was a problem hiding this comment.
Are any of the callers worried?
(I do not see us pass anything but VR_NONE for inds).
There was a problem hiding this comment.
You're right, nobody actually cares right now. And there are other parts of the analysis that are likewise unused.
I'm deliberately leaving it for now. It's possible we'll run across cases where we want to try and use it for something.
|
Failure is #70305. |
Streamline call effects checks. Use wider bit vectors.
Closes #70100.