Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BStrStringMarshaller to source generator #69213

Merged
merged 12 commits into from
May 20, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT commented May 11, 2022

Fixes #69021

/cc @dotnet/interop-contrib

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented May 11, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #69021

Author: AaronRobinsonMSFT
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: 7.0.0

@AaronRobinsonMSFT AaronRobinsonMSFT changed the title Add BStrStringMarshaller to source generator Add BStrStringMarshaller to source generator May 11, 2022
…rtGenerator.Tests/StringTests.cs


Wrong marshalling type.
…pServices/Marshalling/BStrStringMarshaller.cs
…pServices/Marshalling/BStrStringMarshaller.cs

Co-authored-by: Jan Kotas <[email protected]>
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review May 19, 2022 15:53
@AaronRobinsonMSFT
Copy link
Member Author

@jkoritzinsky @elinor-fung Please take a look.

@AaronRobinsonMSFT
Copy link
Member Author

Failure is #65448

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit 810a7f9 into dotnet:main May 20, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the runtime_69021 branch May 20, 2022 14:58
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Provide BSTR marshaller for LibraryImport source generator
4 participants