Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsOSVersionAtLeast when build or revision are not provided #108748

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Fix IsOSVersionAtLeast when build or revision are not provided #108748

wants to merge 15 commits into from
+34 −8

Commits on Oct 10, 2024

  1. Default build and revision numbers to 0 if they are -1 on MacCatalyst

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ee90cab View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Private.CoreLib/src/System/Environment.OS… 

    …Version.MacCatalyst.cs

Co-authored-by: Adeel Mujahid <[email protected]>
    @kotlarmilos @am11
    kotlarmilos and am11 authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    88a187c View commit details
    Browse the repository at this point in the history

  3. Add three-parameter and two-parameter overloads for IsOSPlatformVersi… 

    …onAtLeast
    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    cdd364b View commit details
    Browse the repository at this point in the history

  4. Update IsOSVersionAtLeast to handle not provided values

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3db8a97 View commit details
    Browse the repository at this point in the history

  5. Check only build and revision

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f03783d View commit details
    Browse the repository at this point in the history

  6. Update src/libraries/System.Private.CoreLib/src/System/OperatingSyste… 

    …m.cs

Co-authored-by: Jan Kotas <[email protected]>
    @kotlarmilos @jkotas
    kotlarmilos and jkotas authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ed1959f View commit details
    Browse the repository at this point in the history

  7. Update src/libraries/System.Private.CoreLib/src/System/OperatingSyste… 

    …m.cs

Co-authored-by: Jan Kotas <[email protected]>
    @kotlarmilos @jkotas
    kotlarmilos and jkotas authored Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ad063f5 View commit details
    Browse the repository at this point in the history

  8. New line

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4cb9536 View commit details
    Browse the repository at this point in the history

  9. Update tests to pass when build or revision are -1

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b463233 View commit details
    Browse the repository at this point in the history

  10. Add isCurrentOS to the Assert.Equal

    @kotlarmilos
    kotlarmilos committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a4d1d1d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Unspecified build/revision components are to be treated as zeros

    @kotlarmilos
    kotlarmilos committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    970aa53 View commit details
    Browse the repository at this point in the history

  2. Unspecified build component is to be treated as zero

    @kotlarmilos
    kotlarmilos committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6ff28be View commit details
    Browse the repository at this point in the history

  3. Unspecified build or revision component is to be treated as zero

    @kotlarmilos
    kotlarmilos committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7ac7175 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Update src/libraries/System.Private.CoreLib/src/System/OperatingSyste… 

    …m.cs

Co-authored-by: Adeel Mujahid <[email protected]>
    @kotlarmilos @am11
    kotlarmilos and am11 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3ffaae0 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Private.CoreLib/src/System/OperatingSyste… 

    …m.cs

Co-authored-by: Adeel Mujahid <[email protected]>
    @kotlarmilos @am11
    kotlarmilos and am11 authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    3eb18ad View commit details
    Browse the repository at this point in the history