Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0-rc1] Test fix: Fix IOCP count config var test #106669

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[release/9.0-rc1] Test fix: Fix IOCP count config var test #106669

merged 1 commit into from
Aug 20, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2024 •
edited by kouvel
Loading

Backport of #106664 to release/9.0-rc1

/cc @kouvel

Customer Impact

None

Regression

No

Testing

CI, local

Risk

Low - It's a test fix, only backporting to reduce test failures

@kouvel
Fix IOCP count config var test
0991f08 
The TcpListener was being disposed too early.
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@kouvel kouvel self-assigned this Aug 19, 2024
@kouvel kouvel added this to the 9.0.0 milestone Aug 19, 2024
@kouvel kouvel changed the title [release/9.0-rc1] Fix IOCP count config var test [release/9.0-rc1] Test fix: Fix IOCP count config var test Aug 19, 2024
@kouvel kouvel closed this Aug 20, 2024
@kouvel kouvel reopened this Aug 20, 2024
@carlossanlop
Copy link
Member

carlossanlop commented Aug 20, 2024 •
edited
Loading

I see you also opened a backport for release/9.0: #106670

We don't need two. Just FYI, anything targeting the release/9.0-rc1 will automatically get a PR opened that flows the same change into the release/9.0 branch, which currently represents RC2.

But we don't have runway anymore for merging into RC1. Unless this is absolutely urgent, please close this PR and keep the other one open. Update: I merged this one and will close the other one.

cc @kouvel @eduardo-vp @mangod9 @jeffschwMSFT

jeffschwMSFT
jeffschwMSFT approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take this as tell mode.

cc @carlossanlop

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 20, 2024
@carlossanlop carlossanlop merged commit fe0cfd5 into release/9.0-rc1 Aug 20, 2024
71 of 91 checks passed
@carlossanlop carlossanlop deleted the backport/pr-106664-to-release/9.0-rc1 branch August 20, 2024 17:34
@carlossanlop carlossanlop mentioned this pull request Aug 20, 2024
Closed
This was referenced Aug 20, 2024
Open
Open
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@eduardo-vp eduardo-vp Awaiting requested review from eduardo-vp

@mangod9 mangod9 Awaiting requested review from mangod9

Assignees

@kouvel kouvel

Labels
area-System.Threading Servicing-approved Approved for servicing release
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @jeffschwMSFT @kouvel