Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-compiling CoreCLR from macOS arm64 to x64 #104556

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

akoeplinger
Copy link
Member

It got uncovered by #103801.

This showed up in the VMR since we use arm64 macOS build agents there.

It got uncovered by dotnet#103801.

This showed up in the VMR since we use arm64 macOS build agents there.
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jul 8, 2024

Should all CLR_CMAKE_TARGET_... in this CMakeLists.txt be switched to CLR_CMAKE_HOST_...? The PAL should only ever depend on HOST architecture. It should not ever depend on the TARGET architecture.

@akoeplinger
Copy link
Member Author

Probably yeah, I just wanted to get the build fixed ASAP :)

@akoeplinger akoeplinger merged commit a008f7c into dotnet:main Jul 8, 2024
87 of 89 checks passed
@akoeplinger akoeplinger deleted the fix-osx-x64-cross-compiling branch July 8, 2024 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants