Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Re-try when browser's WBT fail with System.TimeoutException #104481

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jul 5, 2024

Fixes #94240.

Default timeout for Playwright.Chromium.LaunchAsync is 3k ms, we are changing it to 1k ms but in case of timeout, giving it 2 re-tries. Let's see how the CI reacts. (it's green, let's see for a 2nd round to finish)

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Jul 5, 2024
@ilonatommy ilonatommy self-assigned this Jul 5, 2024
@lewing lewing closed this Jul 6, 2024
@lewing lewing reopened this Jul 6, 2024
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@ilonatommy ilonatommy marked this pull request as ready for review July 8, 2024 08:16
@ilonatommy ilonatommy requested a review from maraf as a code owner July 8, 2024 08:16
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy assigned lewing and maraf and unassigned lewing and maraf Jul 8, 2024
@ilonatommy ilonatommy requested a review from lewing July 8, 2024 08:16
@ilonatommy ilonatommy closed this Jul 8, 2024
@ilonatommy ilonatommy reopened this Jul 8, 2024
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ilonatommy ilonatommy merged commit 26b6161 into dotnet:main Jul 8, 2024
24 of 25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] Playwright failing
4 participants