Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

Merged
merged 72 commits into from
Jul 8, 2024
Merged

[cdac] start of RuntimeTypeSystem contract; implement GetMethodTableData SOS method #103444

merged 72 commits into from
Jul 8, 2024

Commits on May 17, 2024

  1. Implement GetThreadStoreData in cDAC

    @elinor-fung
    elinor-fung committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b98afa8 View commit details
    Browse the repository at this point in the history

  2. Add placeholder for getting thread data

    @elinor-fung
    elinor-fung committed May 17, 2024
    Configuration menu
    Copy the full SHA
    890f9c6 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Apply suggestions from code review

    @elinor-fung
    elinor-fung authored May 23, 2024
    Configuration menu
    Copy the full SHA
    41ba95c View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. WIP: Metadata contract

    @lambdageek
    lambdageek committed May 29, 2024
    Configuration menu
    Copy the full SHA
    29214f0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'elinor-fung/cdac-threadstore' into cdac… 

    …-wip
    @lambdageek
    lambdageek committed May 29, 2024
    Configuration menu
    Copy the full SHA
    8beced0 View commit details
    Browse the repository at this point in the history

  3. fix build

    @lambdageek
    lambdageek committed May 29, 2024
    Configuration menu
    Copy the full SHA
    5213286 View commit details
    Browse the repository at this point in the history

  4. WIP: ValidateMethodTable

    @lambdageek
    lambdageek committed May 29, 2024
    Configuration menu
    Copy the full SHA
    622e01a View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. DataCache.GetOrAdd

    @elinor-fung
    elinor-fung committed May 30, 2024
    Configuration menu
    Copy the full SHA
    e112416 View commit details
    Browse the repository at this point in the history

  2. wip

    @lambdageek
    lambdageek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    ae1eac9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'elinor-fung/cdac-threadstore' into cdac… 

    …-wip
    @lambdageek
    lambdageek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    79ea0d4 View commit details
    Browse the repository at this point in the history

  4. checkpoint: ValidateWithPossibleAV

    @lambdageek
    lambdageek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    5c696da View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed May 30, 2024
    Configuration menu
    Copy the full SHA
    6eaf80f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. checkpoint EEClass from MethodTable

    @lambdageek
    lambdageek committed May 31, 2024
    Configuration menu
    Copy the full SHA
    3a7808d View commit details
    Browse the repository at this point in the history

  2. checkpoint: ValidateMethodTablePointer

    @lambdageek
    lambdageek committed May 31, 2024
    Configuration menu
    Copy the full SHA
    66e5476 View commit details
    Browse the repository at this point in the history

  3. cp: delegate from legacy dac

    @lambdageek
    lambdageek committed May 31, 2024
    Configuration menu
    Copy the full SHA
    95914b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. add Metadata to runtime contract descriptor

    @lambdageek
    lambdageek committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    2b8fda3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. checkpoint: more MethodTable fields

    @lambdageek
    lambdageek committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    5c7d2ac View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. checkpoint GetMethodTableData implemented

    @lambdageek
    lambdageek committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    7be5c60 View commit details
    Browse the repository at this point in the history

  2. checkpoint: same answer as legacy dac

    @lambdageek
    lambdageek committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    30b7b26 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    187bcbe View commit details
    Browse the repository at this point in the history

  2. new flags for statics

    @lambdageek
    lambdageek committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    f0d1fcb View commit details
    Browse the repository at this point in the history

  3. fix GCC build

    @lambdageek
    lambdageek committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c53db36 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. WIP: opaque MethodTableHandle

    @lambdageek
    lambdageek committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    b70bb1d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Add contract accessors for MethodTableHandle

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    a65fd50 View commit details
    Browse the repository at this point in the history

  2. fixup

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6f844bf View commit details
    Browse the repository at this point in the history

  3. simplify FreeObjectMethodTable handling

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    76e0384 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    cdb7543 View commit details
    Browse the repository at this point in the history

  5. fixup

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    78830ea View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fbbd45b View commit details
    Browse the repository at this point in the history

  7. [dac] Return canonical MethodTable instead of EEClass 

    Instead of storing the EEClass pointerin
DacpMethodTableData, store the canonical method table instead.

Correspondingly, update GetMethodTableForEEClass to expect a canonical method table pointer instead of an EEClass

Also update cDAC to do likewise
    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    32665b2 View commit details
    Browse the repository at this point in the history

  8. Delete unreferenced MethodTable flags

    @lambdageek
    lambdageek committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    acf8436 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. add Metadata contract doc; fixups

    @lambdageek
    lambdageek committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f246c86 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8409f3e View commit details
    Browse the repository at this point in the history

  2. rename DacpMethodTableData:klass field

    @lambdageek
    lambdageek committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    08d069a View commit details
    Browse the repository at this point in the history

  3. document GetMethodTableData string baseSize adjustment

    @lambdageek
    lambdageek committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    674655f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-Authored-By: Aaron Robinson <[email protected]>
    @lambdageek @AaronRobinsonMSFT
    lambdageek and AaronRobinsonMSFT committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2ae4625 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. fix typo

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e18a2be View commit details
    Browse the repository at this point in the history

  2. rename flag to ContainsGCPointers

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    846e779 View commit details
    Browse the repository at this point in the history

  3. [vm] rename ContainsPointers flag to ContainsGCPointers 

    also rename getter/setter methods in MethodTable
    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    383af83 View commit details
    Browse the repository at this point in the history

  4. code style suggestions from code review

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0f8c7f1 View commit details
    Browse the repository at this point in the history

  5. BUGFIX: read DwFlags2 from the correct offset

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7a337c1 View commit details
    Browse the repository at this point in the history

  6. hide utility methods

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    a7c8158 View commit details
    Browse the repository at this point in the history

  7. remove EEClass_1 struct 

    use Data.EEClass directly in places where we trust an EEClass pointer
    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    f4a3493 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    10624c7 View commit details
    Browse the repository at this point in the history

  9. rename data descriptor members to remove prefixes

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    65cc531 View commit details
    Browse the repository at this point in the history

  10. cleanup the contract docs

    @lambdageek
    lambdageek committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d526087 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. remove hungariant notation prefixes from data descriptors

    @lambdageek
    lambdageek committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0a4112e View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. DAC: always set wNumVirtuals and wNumVtableSlots to 0 

    This information can be retreived from the MethodTable using normal lldb/windbg primitives and doesn't need to be part of the DAC API contract
    @lambdageek
    lambdageek committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1071ca4 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Remove NumVirtuals and NumVtableSlots from Metadata.md 

    Co-authored-by: Jan Kotas <[email protected]>
    @lambdageek @jkotas
    lambdageek and jkotas authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    6c5235c View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    95b728a View commit details
    Browse the repository at this point in the history

  2. "untrusted" -> "non-validated"

    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6573e14 View commit details
    Browse the repository at this point in the history

  3. merge fixup 

    catch System.Exception not Data.Exception
    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    8596892 View commit details
    Browse the repository at this point in the history

  4. remove #if 0

    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    6eabf42 View commit details
    Browse the repository at this point in the history

  5. cleanup

    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4d3200d View commit details
    Browse the repository at this point in the history

  6. pull test target helpers out 

    goal is to be able to use this for testing contracts that depend on some data in the heap
    @lambdageek
    lambdageek committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2e66740 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Add one FreeObjectMethodTable unit test

    @lambdageek
    lambdageek committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8533148 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. clean up the test helpers a bit

    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    77cf405 View commit details
    Browse the repository at this point in the history

  2. validate that a mock system object is a valid method table

    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f9bce4c View commit details
    Browse the repository at this point in the history

  3. code review feedback and more tests: 

    1. rename AttrClass data descriptor field to CorTypeAttr
2. fixup HasComponentSize / RawGetComponentSize comments and code
3. update "system.object" mock methodtable with more field values
4. update "system.string" mock methodtable with more field values
    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    3721992 View commit details
    Browse the repository at this point in the history

  4. Update src/coreclr/gc/env/gcenv.object.h 

    Co-authored-by: Elinor Fung <[email protected]>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1af7c80 View commit details
    Browse the repository at this point in the history

  5. Update src/native/managed/cdacreader/src/Contracts/Metadata_1.MethodT… 

    …ableFlags.cs

Co-authored-by: Elinor Fung <[email protected]>
    @lambdageek @elinor-fung
    lambdageek and elinor-fung authored Jul 2, 2024
    Configuration menu
    Copy the full SHA
    993ae1d View commit details
    Browse the repository at this point in the history

  6. Address code review feedback

    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    f04d880 View commit details
    Browse the repository at this point in the history

  7. move non-validated MethodTable handling to a separate class

    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    76859d1 View commit details
    Browse the repository at this point in the history

  8. clear up ComponentSize contract spec and impl

    @lambdageek
    lambdageek committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a12a407 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. rename Metadata -> RuntimeTypeSystem

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9cf4c5a View commit details
    Browse the repository at this point in the history

  2. add validation failure test; change validation to throw InvalidOperat… 

    …ionException
    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1814848 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into cdac-wip

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    89f98a3 View commit details
    Browse the repository at this point in the history

  4. Update src/native/managed/cdacreader/src/Contracts/RuntimeTypeSystem_… 

    …1.cs

Co-authored-by: Jan Kotas <[email protected]>
    @lambdageek @jkotas
    lambdageek and jkotas authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a0989fa View commit details
    Browse the repository at this point in the history

  5. spellcheck

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    617bf62 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'cdac-wip' of github.com:lambdageek/runtime into cdac-wip

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    815ff0d View commit details
    Browse the repository at this point in the history

  7. Add a generic instance test

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    1ab4f08 View commit details
    Browse the repository at this point in the history

  8. add array instance test

    @lambdageek
    lambdageek committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ee3a362 View commit details
    Browse the repository at this point in the history