Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix data race leading to a deadlock when opening QuicStream #102147

Merged
merged 2 commits into from
May 13, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented May 13, 2024

Backport of #101250

Fixes #101233.
Fixes #100971.
Contributes to #101463

Customer Impact

Customers may encounter a deadlock when attempting to open an outbound QuicStream and the peer closes the connection at the same time.

Regression

No

Testing

Functional tests as part of CI.
Deadlock scenario tested locally by modifying the timing of the operations to make the deadlock more likely.

Risk

Low, issue is well understood and fix affects only code path for opening an outbound QuicStream, which is covered extensively by functional tests.

…01250)

* Fix data race leading to a deadlock.

* Remove unwanted change

* Code review feedback

* Fix hang

* Add assert

* Fix potential crash

* Code review feedback
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@karelz karelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rare deadlock prevention - worth backporting.

@rzikm rzikm requested review from CarnaViire and ManickaP May 13, 2024 15:32
@rzikm rzikm added the Servicing-consider Issue for next servicing release review label May 13, 2024
@rzikm
Copy link
Member Author

rzikm commented May 13, 2024

email sent to shiproom for approval.

@rzikm rzikm added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels May 13, 2024
@rzikm
Copy link
Member Author

rzikm commented May 13, 2024

Approved via email

@rzikm
Copy link
Member Author

rzikm commented May 13, 2024

No CI failures. Good to merge

@rzikm rzikm merged commit 76b5685 into dotnet:release/8.0-staging May 13, 2024
109 of 113 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
@karelz karelz modified the milestones: 8.0.x, 8.0.7 Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants