Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move timing out tests to Outerloop #101556

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Move timing out tests to Outerloop #101556

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Utf8JsonWriterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3069,10 +3069,9 @@ public void WritingHugeBase64Bytes(JsonWriterOptions options)
}

// https://github.com/dotnet/runtime/issues/30746
[Theory]
[Theory, OuterLoop("Very long running test")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test to took 40 seconds to run on my machine, arguably this is too long even for outerloop. I think we could just reduce the amount of inputs being used by this theory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the conditions for the outer loop attribute. It's also showing up in the output I shared for the issue this is fixing.

[MemberData(nameof(JsonOptions_TestData))]
[SkipOnCoreClr("https://github.com/dotnet/runtime/issues/45464", ~RuntimeConfiguration.Release)]
[OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser))]
public void Writing3MBBase64Bytes(JsonWriterOptions options)
{
byte[] value = new byte[3 * 1024 * 1024];
Expand Down Expand Up @@ -4422,7 +4421,7 @@ public void EscapeAsciiCharacters(JsonWriterOptions options)

[Theory]
[MemberData(nameof(JsonOptions_TestData))]
[OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser))]
[OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could probably be restricted to IsMonoInterpreter not all of mono but this is probably fine

public void EscapeCharacters(JsonWriterOptions options)
{
// Do not include surrogate pairs.
Expand Down Expand Up @@ -5305,7 +5304,7 @@ public void WriteDoubleValue(JsonWriterOptions options, double value)
[Theory]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)]
[MemberData(nameof(WriteValue_TestData))]
[OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser))]
[OuterLoop("Too slow", typeof(PlatformDetection), nameof(PlatformDetection.IsMonoRuntime))]
public void WriteNumbers(JsonWriterOptions options, string keyString)
{
var random = new Random(42);
Expand Down
Loading