Initialize m_fInPlaceSS (#109013)

A recent fix added a new field to the DebuggerPatchSkip object and missed initializing it false. This causes the new in-place patch skipping logic activate at random depending on the value of uninitialized memory. Fixing this by initializing the variable. Co-authored-by: Noah Falk <[email protected]> Co-authored-by: Jeff Schwartz <[email protected]>
dotnet · Oct 18, 2024 · ecefb5e · ecefb5e
1 parent 83d152c
commit ecefb5e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/coreclr/debug/ee/controller.cpp b/src/coreclr/debug/ee/controller.cpp
@@ -4334,6 +4334,9 @@ DebuggerPatchSkip::DebuggerPatchSkip(Thread *thread,
                                      DebuggerControllerPatch *patch)
   : DebuggerController(thread, AppDomain::GetCurrentDomain()),
     m_address(patch->address)
+#ifdef OUT_OF_PROCESS_SETTHREADCONTEXT
+    ,m_fInPlaceSS(false)
+#endif
 {
     LOG((LF_CORDB, LL_INFO10000,
          "DPS::DPS: Patch skip 0x%p\n", patch->address));