Remove dependency from OpenTelemetry.Instrumentation.SqlClient

[sebastienros]

Used two a separate forlder for /Shared since I expect the other OTel libraries we need to include will need this too.

See #2819

Microsoft Reviewers: Open in CodeFlow

[eerhardt]

@reyang - Can you review the attribution to ensure we aren't violating the license here?

[reyang]

@rajkumar-rangaraj FYI

[reyang]

@reyang - Can you review the attribution to ensure we aren't violating the license here?

I've added couple suggestions, it looks good to me once these are addressed 👍

[joperezr]

So we decided to go with building their code ourselves as opposed to re-disting their libraries inside our package?

This makes me nervous as we won't be running their tests in this code, nor would we be applying code fixes, and we don't really know how long are we going to be doing this.

Did we explore the option of just harvesting their library and including it in our package instead?

cc @eerhardt

[eerhardt]

So we decided to go with building their code ourselves as opposed to re-disting their libraries inside our package?

This makes me nervous as we won't be running their tests in this code, nor would we be applying code fixes, and we don't really know how long are we going to be doing this.

Did we explore the option of just harvesting their library and including it in our package instead?

cc @eerhardt

Redisting libraries in a nuget package isn't without drawbacks either. If the app brings in the OpenTelemetry.Instrumentation.SqlClient package through another dependency, there will be conflicts since 2 nuget packages brought in the same assembly. We would also need to sign it, etc, in order to redist it.

and we don't really know how long are we going to be doing this.

My understanding from @reyang is that the SqlClient library is targeted to ship stable later this calendar year. But I assume those plans can change. The other one we will need to give the same treatment is the StackExchange.Redis OTel library, which doesn't have a plan on going stable AFAIK.

[eerhardt]

What's this?

[sebastienros]

I think when I imported some source this was required for a specific type. Now not anymore so I assume that I removed a file that was the culprit. Removed.

[eerhardt]

LGTM. Thanks!

[reyang]

@rajkumar-rangaraj @vishweshbankwar some of these settings seem to suggest that OpenTelemetry .NET repo is not following the best practices, would you follow up and see what needs to be updated to have these turned on at repo level? Thanks!

[reyang]

@CodeBlanch FYI