New secure endpoints to obtain products and custom items and dooplugins update on save #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers/refactor-cleanning-api-fields
…ers/refactor-cleanning-api-fields
- Refactor custom attributes - Token auth
vferrero
requested review from
sofia-doofinder,
eduardogomez97 and
pedromcp90
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Show resolved
Hide resolved
pedromcp90
requested changes
Nov 9, 2023
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-custom.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Outdated
Show resolved
Hide resolved
doofinder-for-woocommerce/includes/api/endpoints/class-endpoint-product.php
Show resolved
Hide resolved
…ers/refactor-cleanning-api-fields
- Get custom attributes with get_slugs
vferrero
changed the title
vferrero
changed the title
- Fix thumbnails autogenerate - New param at instalation plugin
Comment on lines
55
to
57
| $img_ori = wp_get_attachment_image_src($thumbnail_id, "full"); | ||
| $img_original["w"] = $img_ori[1] ?? 0; | ||
| $img_original["h"] = $img_ori[2] ?? 0; |
There was a problem hiding this comment.
quizás sacaría esto a otra función igual que tienes la de get_thumbnail_size que fuera get_image_size para que al leer la función se entienda mejor lo que se está queriendo comparar... pero es sólo una sugerencia!
| * @param string $thumbnail_id Thumb ID por check | ||
| * @return string URL of Thumb or false | ||
| */ | ||
| private function check_size_image_url($thumbnail_id){ |
There was a problem hiding this comment.
quizás en vez de check_size_image_url podríai ser get_image_url_by_size ? se me hace raro que sea check pero después devuelva un string o un falso..
…ers/refactor-cleanning-api-fields
vferrero
deleted the
vferrero/pluginrangers/refactor-cleanning-api-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this release we have the following changes: