feat: Add --dialog-dim #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that checking for `not floating -> floating` results in inconsistent behavior when the floating state is toggled, so an all-or-nothing approach seems ideal here. The commented lines are me keeping track of the last_floating state so I can reference this commit later if I need to.
This fixes an issue where dialogs wouldn't be dimmed in workspaces that only have one window (or a fullscreen window).
This makes it possible to increase the dim for dialog boxes.
This makes things easier to remember even though the code isn't exclusive to dialogs.
When setting dialog-dim, it is implied that the user may or may not want to set the dialog-strength as well. Furthermore, the usage of dim-strength by its own wasn't very useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2.