Added 'since' option to search for messages since a certain time #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `since` option under `mailbox` section to search for messages since a certain time instead of going through the complete mailbox during testing scenarios. Acceptable values -`5m|3h|2d|1w`, units - {"m":"minutes", "h":"hours", "d":"days", "w":"weeks"}). Defaults to `1d` if an incorrect value is provided.
- Not to mark messages as read if test option is selected (works only for MSGraphConnection)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 59.88% 58.39% -1.50%
==========================================
Files 12 12
Lines 1578 1620 +42
==========================================
+ Hits 945 946 +1
- Misses 633 674 +41 ☔ View full report in Codecov by Sentry. |
AnaelMobilia
suggested changes
Jun 6, 2024
| messages = connection.fetch_messages(reports_folder, batch_size=batch_size) | ||
| if since: | ||
| _since = 1440 # default one day | ||
| if re.match(r'\d{1,2}[mhd]$', since): |
There was a problem hiding this comment.
Why restrict to two digits ? (eg: 365 days)
I suggest to use \d+ as the next regex
| Ignoring option, fetching messages for last 24hrs" | ||
| .format(since)) | ||
|
|
||
| if isinstance(connection, IMAPConnection): |
There was a problem hiding this comment.
Maybe add a reference to RFC3501 in order to indicate that the restriction (no time, no timezone) is on the SMTP protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sinceoption undermailboxsection to search for messages since a certain time instead of going through the complete mailbox during testing scenarios. Acceptable values -5m|3h|2d|1w, units - {"m":"minutes", "h":"hours", "d":"days", "w":"weeks"}). Defaults to1dif an incorrect value is provided.