Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the syslog2 package to correctly send RFC3164 formatted syslog output #504

Closed
wants to merge 2 commits into from

Conversation

lingfish
Copy link
Contributor

@lingfish lingfish commented Apr 4, 2024

The format that #263 sends isn't technically strict RFC3164; it's more of a raw output, but because it uses Python's SysLogHandler, the PRI is sent, but the HEADER is not.

Merging this in will probably break existing use of this.

Ideally, parsedmarc should also have GELF output, possibly rename the existing feature from #263 to some more like "Raw", and implement this PR.

@seanthegeek
Copy link
Contributor

Yeah, so many people use this project for such a variety of different use cases that I'd rather not break existing functionality. Similar to why I want to be so careful about what I and others do to address #503.

Please update this PR to:

  • Address the code style issue
  • Add the syslog2 to the dependencies list in pyproject.toml
  • Add a format option under the syslog configuration group, with the current raw format being the implicit default, and rfc3164 using syslog2
  • Add details about the configuration options to the documentation, and set format = rfc3164 in the example configuration file

@lingfish
Copy link
Contributor Author

Yeah, all fair points, I kinda mangled this one, and I don't think that syslog2 dep is a good one.. the author has weirdly put debug statements throughout it using print(). I shall work on it.

mkilijanek added a commit to mkilijanek/parsedmarc-src that referenced this pull request May 7, 2024
@lingfish
Copy link
Contributor Author

I'm aborting this PR in favour of implementing GELF logging instead.

@lingfish lingfish closed this Jun 27, 2024
@lingfish lingfish deleted the fix_syslog branch June 27, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants