Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor resultForDefaultIter #2674

Merged
merged 4 commits into from
Sep 27, 2024
Merged

refactor resultForDefaultIter #2674

merged 4 commits into from
Sep 27, 2024

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 23, 2024

Reorganizes some code, and removes one unnecessary sql.Row allocation.
Tiny performance improvement.

@jycor
Copy link
Contributor Author

jycor commented Sep 25, 2024

changes are here: #2676

@jycor jycor closed this Sep 25, 2024
@jycor jycor reopened this Sep 26, 2024
Copy link
Contributor

@max-hoffman max-hoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jycor jycor merged commit 786fe98 into main Sep 27, 2024
8 checks passed
@jycor jycor deleted the james/proj branch September 27, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants