implement charset() function
#2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2024 15:56
fulghum
approved these changes
Sep 17, 2024
| { | ||
| Query: "select charset(null)", | ||
| Expected: []sql.Row{ | ||
| {"binary"}, |
There was a problem hiding this comment.
weird that the docs say charset() returns null if the argument is null. I also see my version of MySQL returning binary here, so looks like MySQL's documentation is incorrect. 🤷🏻
sql/expression/function/collation.go
Outdated
| @@ -144,3 +144,64 @@ func (c *Coercibility) Type() sql.Type { | |||
| func (*Coercibility) CollationCoercibility(ctx *sql.Context) (collation sql.CollationID, coercibility byte) { | |||
| return sql.Collation_binary, 5 | |||
| } | |||
|
|
|||
| // Charset is a function that returns the collation of the inner expression. | |||
There was a problem hiding this comment.
Suggested change
| // Charset is a function that returns the collation of the inner expression. | |
| // Charset is a function that returns the character set of the inner expression. |
sql/expression/function/collation.go
Outdated
| if val == nil { | ||
| return sql.CharacterSet_binary.Name(), nil | ||
| } | ||
| // Otherwise, we return the collation calculated from the expression |
There was a problem hiding this comment.
Suggested change
| // Otherwise, we return the collation calculated from the expression | |
| // Otherwise, we return the character set calculated from the expression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/information-functions.html#function_charset