[Feature] Support custom not found message based on Doctrine Bridge MapEntity #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tricky part is dependency bump, as 6.4 and 7.0 are not supported. Probably it should be new major version of DoctrineMongoDBBundle? |
IonBazan
reviewed
Sep 23, 2024
| ) { | ||
| parent::__construct($class, $objectManager, $expr, $mapping, $exclude, $stripNull, $id, null, $disabled, $resolver); | ||
| parent::__construct($class, $objectManager, $expr, $mapping, $exclude, $stripNull, $id, null, $disabled, $resolver, $message); |
There was a problem hiding this comment.
I think we can avoid locking in ^7.1 by checking if $message property exists in base class. We could also trigger a warning if someone passed the message when using older version of Symfony.
There was a problem hiding this comment.
Done.
Not sure should it be @trigger_error or RuntimeException as trigger_error newer used at the project.
Avariya
force-pushed
the
feature/custom-message
branch
from
b1e808c
to
d18e3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom not found message from ORM bundle.