Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tree] Allow multiple order critieria in reorder and reorderAll #2744

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Waigie
Copy link

@Waigie Waigie commented Jan 11, 2024

The functions \Gedmo\Tree\Entity\Repository\NestedTreeRepository::reorder and \Gedmo\Tree\Entity\Repository\NestedTreeRepository::reorderAll both take the parameters $sortByField and $direction with the type ?string. By allowing string arrays as well, the functions allow reordering with multiple order criteria (e.g. sort by category and date).

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66e6a60) 79.33% compared to head (8a7ced8) 79.26%.

❗ Current head 8a7ced8 differs from pull request most recent head 253b195. Consider uploading reports for the commit 253b195 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
- Coverage   79.33%   79.26%   -0.07%     
==========================================
  Files         162      162              
  Lines        8506     8513       +7     
==========================================
  Hits         6748     6748              
- Misses       1758     1765       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Waigie
Copy link
Author

Waigie commented Jan 24, 2024

Merged the upstream changes, problems should be fixed

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Waigie
Copy link
Author

Waigie commented Sep 14, 2024

Rebase done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants