pipes that call functions #1510

svonworl · 2022-04-22T00:42:47Z

Description
This draft PR explores a technique that harnesses Angular pipes and associated change detection infrastructure to efficiently call functions from our Angular templates.

This PR creates two pipes: function, and method.

The function pipe binds its first argument as this to its second argument, which is a function. The bound function is then called, with the first argument being the pipe input value, and the remaining pipe arguments being the additional function arguments. For example, the Angular expression {{ org | function: this:brace }} maps to the function call this.brace(org)

The method pipe binds the pipe input value as this to its first argument, which is a function. The bound function is then called, with the remaining pipe arguments. For example, the Angular expression {{ org | method: org.getLink }} maps to the method call org.getLink(). A more advanced implementation would also support a string as the first argument, which would name a field of the piped value, and get eval-ed to a function value at run time.

All the example invocations in the PR don't do anything useful at present, and two are broken.

This is a very rough proof-of-concept, not production ready, and should not be merged.

codecov · 2022-04-22T00:46:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd0e07c) 43.86% compared to head (9cc47a2) 43.86%.
Report is 348 commits behind head on develop.

❗ Current head 9cc47a2 differs from pull request most recent head ff58726. Consider uploading reports for the commit ff58726 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1510   +/-   ##
========================================
  Coverage    43.86%   43.86%           
========================================
  Files          312      312           
  Lines         9378     9378           
  Branches      2245     2245           
========================================
  Hits          4114     4114           
  Misses        3433     3433           
  Partials      1831     1831

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.