Update to Go 1.22, Alpine 3.20 #38
Open
+12
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also embeds version numbers directly in the template so they're easier to maintain (since we're not scraping them from anywhere, `versions.json` doesn't add a lot of value here, just overhead). I chose Go 1.22 instead of 1.23 as a temporary measure because of https://go.dev/issues/68976 (and the potential of that to make this harder to test).
|
As noted in #36 (comment), there's a pretty comprehensive smoke test that happens as part of CI in this repository (both the basics, then the full upstream integration tests) which should make this pretty safe to merge, assuming that comes back clean. |
whalelines
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also embeds version numbers directly in the template so they're easier to maintain (since we're not scraping them from anywhere,
versions.jsondoesn't add a lot of value here, just overhead).I chose Go 1.22 instead of 1.23 as a temporary measure because of golang/go#68976 (and the potential of that to make this harder to test).