Shared notary builder #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
shared-builder
branch
from
6a5a258
to
325abe0
Compare
LaurentGoderre
force-pushed
the
shared-builder
branch
4 times, most recently
from
fb9e858
to
3c21df9
Compare
yosifkit
reviewed
Oct 12, 2023
LaurentGoderre
force-pushed
the
shared-builder
branch
2 times, most recently
from
102846b
to
235dd4f
Compare
LaurentGoderre
force-pushed
the
shared-builder
branch
from
235dd4f
to
c599379
Compare
yosifkit
reviewed
Oct 12, 2023
| @@ -31,7 +7,7 @@ ENV INSTALLDIR /notary/server | |||
| ENV PATH=$PATH:${INSTALLDIR} | |||
| WORKDIR ${INSTALLDIR} | |||
|
|
|||
| COPY --from=build /notary-server ./ | |||
| COPY --from=notary:0.7.0-builder /notary-server ./ | |||
There was a problem hiding this comment.
Just to document why the builder image with build tools and both binaries is tagged as 0.7.0-builder instead of builder-0.7.0.
Current image tags are server-0.7.0 and signer-0.7.0 (and aliased without version). I chose [version]-builder over builder-[version] because the builder image is not a specific Notary binary like server and signer are and is mostly an implementation detail of how the others are built.
Happy to change my opinion if the Notary maintainers would rather use builder-0.7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.