Update mentioned php versions that are EOL #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
commented
Jun 23, 2023
|
|
||
| For example, `memcached-2.2.0` has no PHP version constraints (https://pecl.php.net/package/memcached/2.2.0), but `memcached-3.1.4` requires PHP 7.0.0 or newer (https://pecl.php.net/package/memcached/3.1.4). When doing `pecl install memcached` (no specific version) on PHP 5.6, PECL will try to install the latest release and fail. |
There was a problem hiding this comment.
I did not think it was worth finding a new failing example.
yosifkit
commented
Jun 23, 2023
| && tar -xf xcache.tar.gz -C xcache --strip-components=1 \ | ||
| && rm xcache.tar.gz \ | ||
| FROM %%IMAGE%%:8.2-cli | ||
| RUN curl -fsSL '[url-to-custom-php-module]' -o module-name.tar.gz \ |
There was a problem hiding this comment.
Happy to put this back to a real example. xcache.lighttpd.net is 404 and their github mirror hasn't updated for years.
tianon
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update any mentioned module versions so that they build with the latest PHP.