[feat #117] 회원 탈퇴 API #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
2 tasks
Code Coverage
|
Test Results 23 files 23 suites 14s ⏱️ Results for commit f0c3734. ♻️ This comment has been updated with latest results. |
hyun2371
approved these changes
Sep 27, 2024
src/main/java/com/dnd/gongmuin/auth/dto/response/MemberDeletionResponse.java
Outdated
Show resolved
Hide resolved
| requestFactory.setReadTimeout(5000); | ||
|
|
||
| restTemplate.setRequestFactory(requestFactory); | ||
|
|
There was a problem hiding this comment.
OAuth2UnlinkService에서 사용하고 있습니다!
|
|
||
| public Member saveOrUpdate(Oauth2Response oauth2Response) { | ||
| Member member = memberRepository.findBySocialEmail(oauth2Response.createSocialEmail()) | ||
| .map(m -> { | ||
| m.updateSocialEmail(oauth2Response.createSocialEmail()); | ||
| deleteExistingOauthAccessToken(m); | ||
| saveOauth2AccessToken(oauth2Response, m); | ||
| return m; |
There was a problem hiding this comment.
deleteExistingOauthAccessToken()는 이전 소셜 로그인을 통해 저장되어 있는 Oauth2AccessToken가 존재한다면 지운 다음
saveOauth2AccessToken()를 통해 새로운 Oauth2AccessToken()을 저장합니다
There was a problem hiding this comment.
개인적으로 deleteOauthAccessTokenIfExists처럼 네이밍하면 더 명확해질 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
💫 작업 요약
🔍 중점적으로 리뷰 할 부분