Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: allow search filtering in ModelAdmin #2

Open
wants to merge 4 commits into
base: simplify5
Choose a base branch
from

Conversation

Cambis
Copy link

@Cambis Cambis commented Aug 12, 2024

Description

  • The existing functionality passed an ArrayList to a GridField. During search filtering the search context would throw an error because it expects a DataList instead. To address this I have refactored the existing functionality to use a DataList, new code has been included as methods in order to reduce cognitive complexity.

Manual testing steps

  • Go to the workflow model admin
  • Confirm that search filtering works for pending and submitted items

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

- The existing functionality passed an ArrayList to a GridField. During search filtering the search context would throw an error because it expects a DataList instead. To address this I have refactored the existing functionality to use a DataList, new code has been included as methods in order to reduce cognitive complexity.
- Fix for invalid return types in WorkflowService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant