Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v3 #2

Merged
merged 18 commits into from
Mar 18, 2024
Merged

Feature/v3 #2

merged 18 commits into from
Mar 18, 2024

Conversation

eluhr
Copy link
Contributor

@eluhr eluhr commented Mar 8, 2024

As the new usuario version now support anything we do in this package is not really needed anymore. But instead of removing it i would suggest we transform it in some sort of a guide on how to use keycloak as an auth provider in yii2 with some optional files and classes.

@eluhr eluhr requested review from schmunk42 and amk0 March 8, 2024 10:18
@eluhr
Copy link
Contributor Author

eluhr commented Mar 8, 2024

@schmunk42 Added findIdentityByAccessToken example in readme

@eluhr
Copy link
Contributor Author

eluhr commented Mar 8, 2024

I also added a example init.sql dump with a preconfigured example realm and client.

Copy link
Member

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from what I can tell :)

Copy link
Collaborator

@amk0 amk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Only thing would be to check with 2amigos about "2amigos/yii2-usuario": "^1.6.2" version

@eluhr
Copy link
Contributor Author

eluhr commented Mar 12, 2024

For this to work, we need features that are not yet included in a stable usuario release.

@maxxer: When are you planning to release a new version for usuario? Specifically, this involves the following (merged) changes:

@maxxer
Copy link

maxxer commented Mar 13, 2024

I can tag a release later this week

@eluhr
Copy link
Contributor Author

eluhr commented Mar 18, 2024

@maxxer is a release planned for this week?

@maxxer
Copy link

maxxer commented Mar 18, 2024

Tagged 1.6.3 now!

@eluhr eluhr merged commit 6ef035e into master Mar 18, 2024
@eluhr eluhr deleted the feature/v3 branch March 18, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants