-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ocaml-install command #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I apologize on the delay for this, taking a look this week |
too easy bro whenever is good for you <3 |
dmmulroy
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry this took so long to review
dmmulroy
added a commit
that referenced
this pull request
Mar 5, 2024
* add ocaml_install lib structure (#71) * add ocaml_install lib structure * change directory to snake case --------- Co-authored-by: Johann <[email protected]> * From create-melange-app to cma_configuration (#76) * From create-melange-app to cma_configuration * Added components library to theapp is react * merge dev with main (#1) * From create-melange-app to cma_configuration * Added components library to theapp is react * Comment avout open re added * Comment about 'open' re-added * add ; * remove uneeded open --------- Co-authored-by: Dillon Mulroy <[email protected]> * Contributing guide (#78) * Contributing guide * latent addition * bump cli version (#79) 1.0.8 * updates * update ocamlformat * update ocamlformat * add ocaml-install command (#81) * add ocaml-install command * add \n --------- Co-authored-by: Dillon Mulroy <[email protected]> * disable ocaml-install * update deps, melange apis, templates * finish updating to melange v3 --------- Co-authored-by: Johann <[email protected]> Co-authored-by: Johann <[email protected]> Co-authored-by: JoaoAlexNunes <[email protected]> Co-authored-by: metame <[email protected]>
dmmulroy
added a commit
that referenced
this pull request
Mar 5, 2024
* [main] Upgrade project + templates to melange v3 (#89) * add ocaml_install lib structure (#71) * add ocaml_install lib structure * change directory to snake case --------- Co-authored-by: Johann <[email protected]> * From create-melange-app to cma_configuration (#76) * From create-melange-app to cma_configuration * Added components library to theapp is react * merge dev with main (#1) * From create-melange-app to cma_configuration * Added components library to theapp is react * Comment avout open re added * Comment about 'open' re-added * add ; * remove uneeded open --------- Co-authored-by: Dillon Mulroy <[email protected]> * Contributing guide (#78) * Contributing guide * latent addition * bump cli version (#79) 1.0.8 * updates * update ocamlformat * update ocamlformat * add ocaml-install command (#81) * add ocaml-install command * add \n --------- Co-authored-by: Dillon Mulroy <[email protected]> * disable ocaml-install * update deps, melange apis, templates * finish updating to melange v3 --------- Co-authored-by: Johann <[email protected]> Co-authored-by: Johann <[email protected]> Co-authored-by: JoaoAlexNunes <[email protected]> Co-authored-by: metame <[email protected]> * Update README.md (#84) --------- Co-authored-by: Johann <[email protected]> Co-authored-by: Johann <[email protected]> Co-authored-by: JoaoAlexNunes <[email protected]> Co-authored-by: metame <[email protected]> Co-authored-by: Emil Priver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#67
link to closed MR for ref #75