Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest_api paginator: Allows using json_response in place of json_link #533

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Jul 24, 2024

Tell us what you do here

Short description

Related Issues

Implements: dlt-hub/dlt#1632

Additional Context

burnash
burnash previously approved these changes Jul 24, 2024
Copy link
Collaborator

@burnash burnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking, yes, let's do it.

@burnash
Copy link
Collaborator

burnash commented Jul 24, 2024

@willi-mueller the question now is how to deprecate the old config gracefully

@willi-mueller willi-mueller merged commit 123c5be into master Jul 24, 2024
14 checks passed
@willi-mueller willi-mueller deleted the fix/json_response-key-in-paginator-config branch July 24, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants