Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rest_api: Fix dlt init JSONLinkPaginator import error for 0.5.2a1 #532

Merged
merged 3 commits into from
Jul 24, 2024
Merged

rest_api: Fix dlt init JSONLinkPaginator import error for 0.5.2a1 #532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52acde2
Fix dlt init JSONLinkPaginator import error
burnash Jul 24, 2024
1f7a62e
Add a fallback in tests
burnash Jul 24, 2024
d9c2340
Ignore mypy in the import fallback
burnash Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sources/rest_api/config_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,16 @@
BasePaginator,
SinglePagePaginator,
HeaderLinkPaginator,
JSONLinkPaginator,
JSONResponseCursorPaginator,
OffsetPaginator,
PageNumberPaginator,
)

try:
from dlt.sources.helpers.rest_client.paginators import JSONLinkPaginator
except ImportError:
from dlt.sources.helpers.rest_client.paginators import JSONResponsePaginator as JSONLinkPaginator # type: ignore

from dlt.sources.helpers.rest_client.detector import single_entity_path
from dlt.sources.helpers.rest_client.exceptions import IgnoreResponseException
from dlt.sources.helpers.rest_client.auth import (
Expand Down
7 changes: 6 additions & 1 deletion sources/rest_api/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,16 @@
from dlt.sources.helpers.rest_client.paginators import (
SinglePagePaginator,
HeaderLinkPaginator,
JSONLinkPaginator,
JSONResponseCursorPaginator,
OffsetPaginator,
PageNumberPaginator,
)

try:
from dlt.sources.helpers.rest_client.paginators import JSONLinkPaginator
except ImportError:
from dlt.sources.helpers.rest_client.paginators import JSONResponsePaginator as JSONLinkPaginator # type: ignore

from dlt.sources.helpers.rest_client.auth import (
AuthConfigBase,
HttpBasicAuth,
Expand Down
7 changes: 6 additions & 1 deletion tests/rest_api/test_configurations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,18 @@
)
from dlt.sources.helpers.rest_client.paginators import (
HeaderLinkPaginator,
JSONLinkPaginator,
JSONResponseCursorPaginator,
OffsetPaginator,
PageNumberPaginator,
SinglePagePaginator,
)

try:
from dlt.sources.helpers.rest_client.paginators import JSONLinkPaginator
except ImportError:
from dlt.sources.helpers.rest_client.paginators import JSONResponsePaginator as JSONLinkPaginator


from dlt.sources.helpers.rest_client.auth import (
HttpBasicAuth,
BearerTokenAuth,
Expand Down
Loading