Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 274: test if CI accesses secrets on repo forks #246

Closed
wants to merge 1 commit into from

Conversation

willi-mueller
Copy link
Collaborator

@willi-mueller willi-mueller commented Aug 18, 2023

Tell us what you do here

  • implementing verified source (please link a relevant issue labelled as verified source)
  • fixing a bug (please link a relevant bug report)
  • improving, documenting, customizing existing source (please link an issue or describe below)
  • anything else (please link an issue or describe below)

Relevant issue

Reproducing a suspected defect where:

  1. secrets provided in DLT_SECRETS_TOML are not picked up by the CI test runs on forks
  2. changing a single source causes multiple sources to be tested. Adding a new source, however, only causes a run of the new source

I received the shopify secret and added it to github actions.

This reproduces the issue #247

More PR info

Slack conversation with @rudolfix is already running.

@willi-mueller willi-mueller changed the title nonsense change to test if CI accesses secrets on repo forks test if CI accesses secrets on repo forks Aug 18, 2023
@willi-mueller willi-mueller changed the title test if CI accesses secrets on repo forks Issue 274: test if CI accesses secrets on repo forks Aug 18, 2023
@rudolfix
Copy link
Contributor

OK we've got it working on the other PR

@rudolfix rudolfix closed this Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants