Facebook ads datetime object conversion fix. #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolfix
requested changes
Aug 16, 2023
…endulum_datetime.
|
I rebased from master and have removed the breakdown parameter with new commit. |
rudolfix
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
verified source)More PR info
The helper function get_start_date() is using the parse_iso_like_datetime() function to convert the ISO datetime string into pendulum.datetime object. The parse_iso_like_datetime() function can not handle ISO date string and returns an datetime.date object instead of a pendulum.datetime object.
I replace the parse_iso_like_datetime() with ensure_pendulum_datetime function inside the get_start_date(). I also wrote some test to ensure that pendulum.datetime is returned.