Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grammar fix pages 100 - 120 #1908

Merged
merged 4 commits into from
Oct 2, 2024
Merged

docs: grammar fix pages 100 - 120 #1908

merged 4 commits into from
Oct 2, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Oct 1, 2024

Description

docs: grammar fix pages 100 - 120

@sh-rp sh-rp marked this pull request as ready for review October 1, 2024 15:00
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 591a60c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66fd1c071881ed0008fdf1ca
😎 Deploy Preview https://deploy-preview-1908--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing checker! Few comments:

  1. One broken link (that's why deploy preview failed)
  2. He tried to change the structure of the document several times (replaced ## to###)
  3. Checker does not always change titles correctly (I changed it back)

@burnash burnash added the documentation Improvements or additions to documentation label Oct 1, 2024
@sh-rp sh-rp merged commit c312fb4 into devel Oct 2, 2024
50 of 51 checks passed
@sh-rp sh-rp deleted the docs/grammar-100-120 branch October 2, 2024 10:14
* files created between the **normalize** and **load** stages are the same files that will be loaded to destination.
### Controlling intermediary file size and rotation
`dlt` writes data to intermediary files. You can control the file size and the number of created files by setting the maximum number of data items stored in a single file or the maximum single file size. Keep in mind that the file size is computed after compression has been performed.
* `dlt` uses a custom version of the [`jsonl` file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `dlt` uses a custom version of the [`jsonl` file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages.
* `dlt` uses a custom version of the [JSONL file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants