-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: grammar fix pages 100 - 120 #1908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing checker! Few comments:
- One broken link (that's why deploy preview failed)
- He tried to change the structure of the document several times (replaced
##
to###
) - Checker does not always change titles correctly (I changed it back)
docs/website/docs/dlt-ecosystem/verified-sources/sql_database/advanced.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/rest_api/basic.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/rest_api/basic.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/rest_api/basic.md
Outdated
Show resolved
Hide resolved
docs/website/docs/dlt-ecosystem/verified-sources/sql_database/advanced.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alena Astrakhantseva <[email protected]>
…c.md Co-authored-by: Alena Astrakhantseva <[email protected]>
…c.md Co-authored-by: Alena Astrakhantseva <[email protected]>
burnash
reviewed
Oct 2, 2024
* files created between the **normalize** and **load** stages are the same files that will be loaded to destination. | ||
### Controlling intermediary file size and rotation | ||
`dlt` writes data to intermediary files. You can control the file size and the number of created files by setting the maximum number of data items stored in a single file or the maximum single file size. Keep in mind that the file size is computed after compression has been performed. | ||
* `dlt` uses a custom version of the [`jsonl` file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
* `dlt` uses a custom version of the [`jsonl` file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages. | |
* `dlt` uses a custom version of the [JSONL file format](../dlt-ecosystem/file-formats/jsonl.md) between the **extract** and **normalize** stages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
docs: grammar fix pages 100 - 120