-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds registries and plugins #1894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rename, wraps standalone resources
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…override old documents and preserve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced changes
Annotated
, not aNewType
which allows to use regular ie. string as initializers without typechecker complaining. also secret types can be dynamically created without breaking any rulesdtl.source
decorator createsDltSourceFactoryWrapper
instead of wrapping source function. this class is callable, preserves signature and allows to rename the source and change other parameters at runtime (with_args
). see how this is applied inrest_api
RunContext
is a new context available via Container that tellsdlt
where is the current run root, settings folder (ie. toml files), data folder (with pipelines dir) etc. a default context is using the same paths that were "hardcoded" before.pluggy
is added with one hook active that allows to override the default run context with plugged class. There's also an example and a test. works pretty well.pluggy
is also an injected context. so it is created on demand and in theory can also be a plugin :)with shorthands
<section/module>.<function/name>
- run context name taken from run context<section/module>
if equals function name (ie sql_database is a valid reference)when source is being added to a registry, the name of current run context is used
references not in registry will be assumed to be importable python modules with fortmat exactly like we use in the destination.
Less important changes:
TODO in this PR:
from_reference
in SourceReference. todlt
(defaullt) run context if we cannot resolve for current run context (sosql_database
will resolve in any context)runtime
testsTODO in next PR:
destination
decoratorresolve_configuration