Docs: Grammar action, satisfaction! First 20 pages. #1817

sh-rp · 2024-09-16T13:36:16Z

Description

Runs our grammar checker on all docs pages

netlify · 2024-09-16T13:36:30Z

✅ Deploy Preview for dlt-hub-docs ready!

Name	Link
🔨 Latest commit	`342967c`
🔍 Latest deploy log	https://app.netlify.com/sites/dlt-hub-docs/deploys/66ec248d56279f00081f4e6a
😎 Deploy Preview	https://deploy-preview-1817--dlt-hub-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sh-rp · 2024-09-16T13:54:51Z

docs/website/docs/general-usage/schema.md


 ### Table references
-You can annotate tables with table references. This feature is coming soon.
+You can annotate tables with table references. This feature is coming soon.## Schema settings


this header moved down here, maybe write a regex to find these kind of occurences

change model fix chunking

fix lint fix grammar script add offset limit functionailty for grammar checker

docs/website/docs/general-usage/data-enrichments/user_agent_device_data_enrichment.md

docs/website/docs/general-usage/destination-tables.md

docs/website/docs/general-usage/full-loading.md

burnash · 2024-09-19T12:03:05Z

docs/website/docs/general-usage/incremental-loading.md

@@ -33,19 +28,15 @@ using `primary_key`. Use `write_disposition='merge'`.

 </div>

-The "write disposition" you choose depends on the data set and how you can extract it.
+The "write disposition" you choose depends on the dataset and how you can extract it.


This is a strange change as I think both terms are valid

We use dataset throughout the docs and in the code, so I would say it is good, no?

docs/website/docs/general-usage/incremental-loading.md

docs/website/docs/general-usage/naming-convention.md

docs/website/docs/general-usage/pipeline.md

burnash · 2024-09-19T12:55:09Z

docs/website/docs/general-usage/resource.md

@@ -155,7 +145,7 @@ def repo_events() -> Iterator[TDataItems]:

 # the `table_schema` method gets the table schema generated by a resource and takes an optional
 # data item to evaluate dynamic hints
-print(repo_events().compute_table_schema({"type": "WatchEvent", id:...}))
+print(repo_events().compute_table_schema({"type": "WatchEvent", "id": ...}))


docs/website/docs/general-usage/resource.md

docs/website/docs/general-usage/schema-contracts.md

docs/website/docs/general-usage/schema-evolution.md

docs/website/docs/general-usage/schema.md

burnash

Awesome work, @sh-rp! Thank you!

sh-rp force-pushed the docs/grammar branch from ee80356 to 3b929be Compare September 16, 2024 13:37

sh-rp commented Sep 16, 2024

View reviewed changes

sh-rp force-pushed the docs/grammar branch 4 times, most recently from 0f34262 to 4c00c9b Compare September 17, 2024 08:16

sh-rp force-pushed the devel branch from fcef84c to 7b6470f Compare September 17, 2024 08:20

sh-rp force-pushed the docs/grammar branch 3 times, most recently from 6e50af1 to c701c09 Compare September 17, 2024 10:00

sh-rp force-pushed the devel branch from ec730e8 to fcc4c45 Compare September 17, 2024 10:04

sh-rp force-pushed the docs/grammar branch 7 times, most recently from 7600760 to 97f2ac2 Compare September 17, 2024 16:15

sh-rp added 4 commits September 19, 2024 09:24

update prompt

2372603

change model fix chunking

add sanity check and switch back to gpt 4

9012651

fix lint

0515f6c

fix lint fix grammar script add offset limit functionailty for grammar checker

first 20 pages

30bd323

sh-rp force-pushed the docs/grammar branch from 97f2ac2 to 30bd323 Compare September 19, 2024 08:09

sh-rp changed the title ~~Docs: Grammar action, satisfaction!~~ Docs: Grammar action, satisfaction! First 20 pages. Sep 19, 2024