Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix broken code detection/highlighting #1810

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Sep 15, 2024

Screenshot 2024-09-16 at 00 09 39

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 67a9bf8
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e7d441308ca8000811a75b
😎 Deploy Preview https://deploy-preview-1810--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

| id | name | created_at |
| --- | --- | --- |
| 1 | Alice | 2024-07-01 |
| 2 | Bob | 2024-07-02 |

2. The python code illustrates the process of loading data from an SQL source into BigQuery using the `dlt` pipeline.
Please note the `write_disposition = "replace”` used below.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dat-a-man A new line after a numbered list item was the reason why the code block didn't render properly (see the screenshot)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @burnash, thanks for looking into it. Do you see some snippets and tables broken in deploy preview here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dat-a-man no, I think I fixed all of them for this page

@burnash burnash merged commit 4127a6c into devel Sep 16, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants