-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable BigQuery schema auto-detection with partitioning and clustering hints #1806
Merged
rudolfix
merged 7 commits into
devel
from
1746-when-using-bigquery-as-a-destination-adapter-settings-partition-and-autodetect_schema-are-exclusive
Sep 14, 2024
Merged
Enable BigQuery schema auto-detection with partitioning and clustering hints #1806
rudolfix
merged 7 commits into
devel
from
1746-when-using-bigquery-as-a-destination-adapter-settings-partition-and-autodetect_schema-are-exclusive
Sep 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Signed-off-by: Marcel Coetzee <[email protected]>
Pipboyguy
requested review from
sh-rp and
rudolfix
and removed request for
sh-rp
September 13, 2024 16:11
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…dapter-settings-partition-and-autodetect_schema-are-exclusive
rudolfix
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thx for the test! I moved the pipeline tests to a right file (table builder tests have grown too much)
rudolfix
deleted the
1746-when-using-bigquery-as-a-destination-adapter-settings-partition-and-autodetect_schema-are-exclusive
branch
September 14, 2024 07:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the BigQuery destination to support schema auto-detection while allowing user-defined partitioning and clustering hints. It addresses the limitation where using
autodetect_schema=True
previously ignored other table optimization hints.Related Issues
partition
andautodetect_schema
are exclusive #1746