Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BigQuery schema auto-detection with partitioning and clustering hints #1806

Conversation

Pipboyguy
Copy link
Collaborator

Description

This PR enhances the BigQuery destination to support schema auto-detection while allowing user-defined partitioning and clustering hints. It addresses the limitation where using autodetect_schema=True previously ignored other table optimization hints.

Related Issues

@Pipboyguy Pipboyguy self-assigned this Sep 13, 2024
@Pipboyguy Pipboyguy requested review from sh-rp and rudolfix and removed request for sh-rp September 13, 2024 16:11
@Pipboyguy Pipboyguy added the bug Something isn't working label Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 3243025
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66e4985b4bfb860008bf97ec
😎 Deploy Preview https://deploy-preview-1806--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pipboyguy Pipboyguy added the destination Issue related to new destinations label Sep 13, 2024
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx for the test! I moved the pipeline tests to a right file (table builder tests have grown too much)

@rudolfix rudolfix merged commit 325d927 into devel Sep 14, 2024
58 checks passed
@rudolfix rudolfix deleted the 1746-when-using-bigquery-as-a-destination-adapter-settings-partition-and-autodetect_schema-are-exclusive branch September 14, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working destination Issue related to new destinations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

When using BigQuery as a destination, adapter settings partition and autodetect_schema are exclusive
2 participants